Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dependencies and format hfvqe/quickstart #102

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

mpharrigan
Copy link
Collaborator

@mpharrigan mpharrigan commented Nov 20, 2020

Add notebook buttons, installation step, and some very minor code style adjustments.

Partially address #101. Re-work molecular_exmaple.py to
support putting these data files elsewhere in the future. Run nbfmt.

cc #83

@mpharrigan mpharrigan added documentation Improvements or additions to documentation hfvqe labels Nov 20, 2020
Partially address quantumlib#101. Re-work `molecular_exmaple.py` to
support putting these data files elsewhere in the future.
Copy link
Collaborator

@lamberta lamberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're in here, can you shorten the heading title for: ### Generate the input files, set up quantum resources, and set up the OpdmFunctional to make measurements. ?

Can use a shorter section title so it doesn't run over in the nav and use that as the setence description that follows.

@mpharrigan
Copy link
Collaborator Author

reworked the headings

Copy link
Collaborator

@lamberta lamberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@mpharrigan
Copy link
Collaborator Author

I'll give @ncrubin a beat to look this over, just in case

@mpharrigan mpharrigan merged commit c873c64 into quantumlib:master Nov 30, 2020
@mpharrigan mpharrigan deleted the 2020-11-docs-3 branch November 30, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hfvqe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants